-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUDA patch #449
base: master
Are you sure you want to change the base?
CUDA patch #449
Conversation
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
===========================================
- Coverage 66.61% 30.91% -35.70%
===========================================
Files 67 31 -36
Lines 4211 1695 -2516
===========================================
- Hits 2805 524 -2281
+ Misses 1406 1171 -235 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@Roger-luo What's going on in this PR and can I help out? |
I realize I need to write a sampler on CUDA, but haven't had the chance to write it, it should be simple. Otherwise, we can dispatch single measurement to CPU. I can let you work on it if you want to try some CUDA programming in Julia. |
|
||
end | ||
|
||
function CuYao.cu(reg::SubspaceArrayReg{D}) where {D} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think SubspaceArrayReg
already overloaded adapt
thus adapt(CuArray, reg)
should just work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have missed that
lib/BloqadeCUDA/test/subspace.jl
Outdated
using BloqadeCUDA | ||
|
||
|
||
struct Sampler{A,B} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can start with a simple version without these abstractions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can't seem to figure out how to make the kernel compile without the abstractions.
It is complaining about searchsortedfirst
being called inside the map kernel.
No description provided.