Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V1xGenerator and V3xGenerator. #1

Merged
merged 8 commits into from
Jan 24, 2024
Merged

Conversation

rturrado
Copy link
Contributor

@rturrado rturrado commented Jan 19, 2024

As subclasses of Generator. With slightly different implementations.

Update C++ version to C++23.

Remove build_tests option from conan profiles.

As subclasses of Generator.
With slightly different implementations.

Update C++ version to C++23.

Remove build_tests option from conan profiles.
@rturrado rturrado requested a review from pablolh January 19, 2024 00:05
src/main.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
Copy link

@pablolh pablolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@rturrado rturrado merged commit 1935e2d into master Jan 24, 2024
12 checks passed
@rturrado rturrado deleted the v1x_and_v3x_generators branch January 24, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants