Fix measure instruction #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class serves as a base class for 'instruction' and 'measure_instruction'. A 'measure_instruction' has a 'lhs' operand, and a 'rhs' operand. The names have been chosen to be similar to v1x assignment instructions. A measure instruction is kind of an assignment from qubits to bits, with a left hand side expression and a right hand side expression. These operands can be multi-index, but not lists of expressions. The current instruction resolver cannot deal yet with instructions accepting a variadic list of arguments. Removed request_qubit_and_bit_indices_have_same_size member from Instruction. This check is now implicit for a measure instruction. parsing.cpp: - Updated parameter order when registering a measure instruction. - The order is now left to right, bit to qubit.
This is not really part of this PR. But I saw it yesterday going through the code with Chris, and I take the opportunity to remove it.
pablolh
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an
instruction_baseclass to the tree-gen syntactic AST.This class serves as a base class for
instructionandmeasure_instruction.A
measure_instructionhas alhsoperand, and arhsoperand.The names have been chosen to be similar to v1x assignment instructions.
A measure instruction is kind of an assignment from qubits to bits, with a left hand side expression and a right hand side expression.
These operands can be multi-index, but not lists of expressions.
The current instruction resolver cannot deal yet with instructions accepting a variadic list of arguments.
Removed
request_qubit_and_bit_indices_have_same_sizemember fromInstruction.This check is now implicit for a measure instruction.
parsing.cpp: