One single version of truth #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Then made this definition available to Python code through get_version method at version.py. And used this method from setup.py. This is very similar to what is done at the moment for the QX simulator. The main difference is that I've put the implementation of the get_version method in a version.py file. I've done this because I think, in the future, it may be needed to access this get_version method from conanfile.py.
And set 'version' using 'get_version()'. This can be accomplished by exporting 'version.py' and 'include/version.hpp' together with the 'conanfile.py'.
pablolh
reviewed
Nov 27, 2023
pablolh
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
include/version.hppto definelibqasmversion in a single place.Then made this definition available to Python code through the
get_versionmethod atversion.py.And used this method from
setup.py.This is very similar to what is done at the moment for the QX simulator.
The main difference is that I've put the implementation of the get_version method in a
version.pyfile.I've done this because I think that, in the future, it may be needed to access this
get_versionmethod fromconanfile.py.