Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QI2-1119] Support running in an existing event loop (i.e. jupyter notebook) #36

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

napocornejo
Copy link
Contributor

No description provided.

@eendebakpt
Copy link
Contributor

@napocornejo Tested and works under spyder!

eliasKA
eliasKA previously approved these changes Oct 21, 2024
Copy link
Contributor

@eliasKA eliasKA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅, one small suggestion for possibly rewriting run_async method but feel free to continue without it.

qiskit_quantuminspire/utils.py Outdated Show resolved Hide resolved
eliasKA
eliasKA previously approved these changes Oct 21, 2024
@napocornejo napocornejo force-pushed the feature/QI2-1119/async-jupyter branch from ad022e6 to d1dd056 Compare October 21, 2024 11:47
@napocornejo napocornejo merged commit 76bffe9 into master Oct 21, 2024
22 checks passed
@napocornejo napocornejo deleted the feature/QI2-1119/async-jupyter branch October 21, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants