Improve ObjectStore root config handling (#8445)

QuantConnect · Dec 4, 2024 · 9955892 · 9955892
1 parent a2efee8
commit 9955892
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/Engine/Storage/LocalObjectStore.cs b/Engine/Storage/LocalObjectStore.cs
@@ -54,7 +54,7 @@ public class LocalObjectStore : IObjectStore
         /// <summary>
         /// Gets the default object store location
         /// </summary>
-        public static string DefaultObjectStore => Path.GetFullPath(Config.Get("object-store-root", "./storage"));
+        public static string DefaultObjectStore { get; set; } = Path.GetFullPath(Config.Get("object-store-root", "./storage"));
 
         /// <summary>
         /// Flag indicating the state of this object storage has changed since the last <seealso cref="Persist"/> invocation

diff --git a/Tests/Common/Storage/LocalObjectStoreTests.cs b/Tests/Common/Storage/LocalObjectStoreTests.cs
@@ -23,7 +23,6 @@
 using QuantConnect.Storage;
 using QuantConnect.Research;
 using System.Collections.Generic;
-using QuantConnect.Configuration;
 using QuantConnect.Lean.Engine.Storage;
 using System.Threading;
 
@@ -33,15 +32,15 @@ namespace QuantConnect.Tests.Common.Storage
     public class LocalObjectStoreTests
     {
         private static readonly string TestStorageRoot = $"{Directory.GetCurrentDirectory()}/{nameof(LocalObjectStoreTests)}";
-        private static readonly string StorageRootConfigurationValue = Config.Get("object-store-root");
+        private static readonly string StorageRootConfigurationValue = LocalObjectStore.DefaultObjectStore;
 
         private ObjectStore _store;
         private ILogHandler _logHandler;
 
         [OneTimeSetUp]
         public void Setup()
         {
-            Config.Set("object-store-root", TestStorageRoot);
+            LocalObjectStore.DefaultObjectStore = TestStorageRoot;
             #pragma warning disable CA2000
             _store = new ObjectStore(new TestLocalObjectStore());
             #pragma warning restore CA2000
@@ -55,15 +54,14 @@ public void Setup()
         public void Cleanup()
         {
             _store.DisposeSafely();
-            Config.Set("object-store-root", StorageRootConfigurationValue);
+            LocalObjectStore.DefaultObjectStore = StorageRootConfigurationValue;
             try
             {
                 Directory.Delete(TestStorageRoot, true);
             }
             catch
             {
             }
-            Config.Reset();
 
             // Restore initial Log Handler
             Log.LogHandler = _logHandler;