Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature:Binance: Futures models support StopMarket OrderType #8441

Conversation

Romazes
Copy link
Collaborator

@Romazes Romazes commented Dec 3, 2024

Description

Support for the Stop Market order type for Binance cryptocurrency futures.

Related PRs

Related Issue

Motivation and Context

Support new order types so users can create new algorithms using them.

Requires Documentation Change

N/A

How Has This Been Tested?

  • Add additional test case to validate:
    • We can not place StopMarket with SecurityType.Crypto in Binance.
    • We can place StopMarket with SecurityType.CryptoFutures in Binance.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

test:feat: CanSubmit StopMarket Crypto or CryptoFuture in Binance Model
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Martin-Molinero Martin-Molinero merged commit a2efee8 into QuantConnect:master Dec 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants