Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entanglement simulation on a grid with custom predicates #90
Entanglement simulation on a grid with custom predicates #90
Changes from all commits
f9cc7ac
962f5d6
5b726da
7d1b3fc
1f98123
f9c5f90
b127a3e
cfe1f31
7547205
2943e2e
427e079
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am waiting on CI and will then merge. However, this is an O(n) check for something that should be O(1).
From a node index get its x y coordinates (currently you get only one of them).
Then do the same for the other node.
Then just compare them to verify that you are to the left (one comparison) and to the top (second comparison).
No need for a for loop.
Submit a PR with the fix and feel free to merge it. It should also make this function much simpler.