Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow strings in args #24

Merged
merged 5 commits into from
Nov 30, 2023
Merged

allow strings in args #24

merged 5 commits into from
Nov 30, 2023

Conversation

ba2tro
Copy link
Member

@ba2tro ba2tro commented Nov 28, 2023

fixes #23

@Krastanov
Copy link
Member

after you get the buildkite PR to run, and you have tests here passing, feel free to merge without waiting for me

add release notes in the CHANGELOG, bump the version number in Project.toml and use JuliaRegistrator to make a new release

The changelog updates can be something along the lines "improvements to tests and documentation support" given that there are no user-facing changes or improvements. No need to write much text there at all.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e06c171) 57.50% compared to head (0a32ac6) 57.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   57.50%   57.50%           
=======================================
  Files          14       14           
  Lines         433      433           
=======================================
  Hits          249      249           
  Misses        184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Krastanov
Copy link
Member

Just FYI, the makedocs call needs to be updated because a breaking release of Documenter was made between our last release and today. We had to make the same update to QuantumClifford and QuantumSavory

@ba2tro ba2tro merged commit f37a9a1 into QuantumSavory:main Nov 30, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@withmetadata doesn't work with docstrings
2 participants