Update Web3Q validator set from PoS staking contract in remote chain #78
Conversation
| epochId := header.Number.Uint64() / s.config.Epoch | ||
| remoteChainNumber := uint64(0) | ||
| hash, emptyHash := common.Hash{}, common.Hash{} | ||
| if s.config.ValidatorChangeEpochId > 0 && s.config.ValidatorChangeEpochId <= epochId { |
There was a problem hiding this comment.
This condition is used twice in the call
- here
- in NextValidatorsAndPowersAt(...)
In fact, I think it is better to use the condition once, i.e., adding
} else { header := g.chain.GetHeaderByNumber(0) validators = header.NextValidators; powers = header.NextValidatorPowers; }
and simplify the logic of NextValidatorsAndPowersAt (and move the call of NextValidatorsAndPowersAt() of course).
This also removes a wired call that if this condition is not satisfied, NextValidatorsAndPowersAt is called remoteChainNumber 0 and emptyHash.
| remoteChainNumber := uint64(0) | ||
| hash := common.Hash{} | ||
|
|
||
| header.NextValidators, header.NextValidatorPowers, remoteChainNumber, hash, err = |
There was a problem hiding this comment.
A thought for better readability: since s.config.ValidatorChangeEpochId and s.config.ValidatorChangeEpochId <= epochId are already used in ValidateBlock(), we should have the mirrored logic here, i.e., if the condition is not satisfied, use genesis validators.
…to update_validator_set
https://github.com/QuarkChain/web3q-master-task/issues/37