Add UNIX wildcards support #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimirjamali
force-pushed
the
wildcard_plus_uuid
branch
from
f6e7649
to
2af5ee3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
+ Coverage 75.10% 75.17% +0.06%
==========================================
Files 52 52
Lines 8552 8619 +67
==========================================
+ Hits 6423 6479 +56
- Misses 2129 2140 +11 ☔ View full report in Codecov by Sentry. |
|
CI/CD tests are all green. I shall proceed with the unittests if the overall patch is approved. |
marmarek
requested changes
Oct 27, 2024
alimirjamali
force-pushed
the
wildcard_plus_uuid
branch
from
2af5ee3
to
bdb2cf4
Compare
alimirjamali
changed the title
alimirjamali
force-pushed
the
wildcard_plus_uuid
branch
3 times, most recently
from
6713031
to
631b1e7
Compare
|
yes, looks good, please add a test :) |
alimirjamali
force-pushed
the
wildcard_plus_uuid
branch
from
631b1e7
to
86a7a1e
Compare
Allowing user to select qubes using UNIX like wildcards
alimirjamali
force-pushed
the
wildcard_plus_uuid
branch
from
86a7a1e
to
ba2da17
Compare
It is done. All 4 CI/CD checks are green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing user to select qubes with UNIX like wildcards for multiple qube selection