Handle HTTP & HTTPS URLs in dom0 & GUIVMs

[alimirjamali]

A new qubes-virtual-browser tool is made to handle URLs within dom0 and/or GUIVMs. It could safely open URLs via DisposableVMs, copy them to global clipboard or discard them.

resolves: QubesOS/qubes-issues#8171

[alimirjamali]

PipelineRetryFailed

[alimirjamali]

@marmarta pylint and unittests for this one are green. Builds fail. I could not fully understand the logs. Advise is highly appreciated.

[marmarta]

xdg-settings is not installed in the environment, so the build process fails: the package containing it must be added to the spec / control files.

[codecov]

Codecov Report

Attention: Patch coverage is 63.54167% with 35 lines in your changes missing coverage. Please review.

Project coverage is 93.19%. Comparing base (2b308a5) to head (0a165a1).

Files with missing lines	Patch %	Lines
qubes_config/global_config/global_config.py	63.44%	34 Missing ⚠️
qubes_config/policy_editor/policy_editor.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   93.43%   93.19%   -0.24%     
==========================================
  Files          57       57              
  Lines       10999    11083      +84     
==========================================
+ Hits        10277    10329      +52     
- Misses        722      754      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[alimirjamali]

The CI/CD tests are finally green. I will proceed with unittests. But overall this should be ready for testing

[marmarek]

It got few conflicts now... can you rebase?

[alimirjamali]

It got few conflicts now... can you rebase?

Sure. Will do it this afternoon after writing the weekly newsletter.

[marmarek]

Will do it this afternoon after writing the weekly newsletter.

This one will be a big one, major devices API change got merged finally, more context at QubesOS/qubes-issues#9325

[alimirjamali]

Will do it this afternoon after writing the weekly newsletter.

This one will be a big one, major devices API change got merged finally, more context at QubesOS/qubes-issues#9325

Yes. I saw that when rebasing the --version patch for core-admin-linux. Only 60 PRs by Piotr were there.

[alimirjamali]

It got few conflicts now... can you rebase?

Ok. This got finally rebased and conflicts are solved. I got busy recently and it took some time.

There are few pending minor issues.

1. For the recently merged --open option (Add -o/--open-at option to global config #227), we should decide if the URL page of Global Config should have separate bookmarks for this tool config and the policies. Please let me know If I should add it.
2. I did not write the unittests yet. This commit is already big and hard for review. I guess the unittests could be a separate PR or another commit in this PR.

[marmarek]

Looking at this, what do you think about unifying it a bit with AppVM URL opening script? We already have a possibility (much simpler) to open URLs in another VM, and it's already configurable in the global config tool. That one won't work directly in dom0 as qrexec calls from dom0 are different. But maybe this tool can be unified to reuse more of that? I mean it both ways:

• make it consider policy even when running in dom0 (that might need extending qrexec-policy-exec --just-evaluate tool to return more info than just allow/deny via exit code) to unify configuration
• make it work in appvm too (without ability to list all VMs, without reading features directly etc); if running outside of dom0/guivm, action of copying to the global clipboard would need to be disabled

What do you think?

[alimirjamali]

What do you think?

It should be doable. I can work on it. I appreciate if I could have some advise on the priority of this one vs the pending clipboard PRs (timeout feature and multi-paste feature). For which ones should I spend more time?

[marmarek]

I'd say clipboard timeout feature should come first