Provide proper unmap notifications to GUI agent #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GUI agent needs to know when grants it has sent are _unmapped_, not just mapped. Linux provides IOCTL_GNTDEV_SET_UNMAP_NOTIFY which can be used for this purpose. Add a new protocol message designed to use this feature.
DemiMarie
force-pushed
the
unmap-notify
branch
from
dae27af
to
d30f00c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GUI agent needs to know when grants it has sent are unmapped, not just mapped. Linux provides IOCTL_GNTDEV_SET_UNMAP_NOTIFY which can be used for this purpose. Add a new protocol message designed to use this feature. Also use proper flexible array members instead of empty arrays.