Fix some parsing logic in meminfo-writer #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a security issue as the input is trusted.
|
PipelineRetry |
|
PipelineRetryFailed |
marmarek
reviewed
Oct 11, 2022
| } else if (key == *(unsigned long long *) "SwapFree:") { | ||
| SwapFree = val; | ||
| nitems |= 32; | ||
| switch (*ptr) { |
There was a problem hiding this comment.
This function is executed at least 10 times per second, in every VM. Can you verify that your change do not make it any slower than it was? For example extract it into a tight loop and measure time for 10000 iterations or such.
marmarek
requested changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a security issue as the input is trusted.