Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 - Removing redundant dependency injection code #1139

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

v2 - Removing redundant dependency injection code #1139

wants to merge 2 commits into from

Conversation

pdelewski
Copy link
Contributor

@pdelewski pdelewski commented Dec 23, 2024 •
edited
Loading

This PR removes some redundant code already handled by embedded struct

@pdelewski pdelewski changed the title Removing redundant dependency injection code as all this is handled b… Removing redundant dependency injection code Dec 23, 2024
@pdelewski pdelewski changed the title Removing redundant dependency injection code v2 - Removing redundant dependency injection code Dec 23, 2024
@pdelewski pdelewski marked this pull request as ready for review December 23, 2024 11:16
@pdelewski pdelewski requested a review from a team as a code owner December 23, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trzysiek trzysiek trzysiek approved these changes

@nablaone nablaone Awaiting requested review from nablaone nablaone is a code owner automatically assigned from QuesmaOrg/engineering

@jakozaur jakozaur Awaiting requested review from jakozaur jakozaur is a code owner automatically assigned from QuesmaOrg/engineering

@mieciu mieciu Awaiting requested review from mieciu mieciu is a code owner automatically assigned from QuesmaOrg/engineering

@avelanarius avelanarius Awaiting requested review from avelanarius avelanarius is a code owner automatically assigned from QuesmaOrg/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdelewski @trzysiek