Combine schema and JSON types for Array fields #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a table, Quesma uses both the schema information (which can come from "PUT /:index/_mapping" or YAML configuration) and the inferred types from JSON. However, the schema information does not contain knowledge whether a field is an array or not - in ElasticSearch essentially every field can become an array (a field with type "keyword" can receive an array of keywords). Therefore Quesma has to handle arrays in a different way. Previously if it detected an array, it would not use schema information at all. This PR improves this logic - schema information is now combined with the JSON information (that a field is actually an array).
|
Still working on it - after fixing this bug, now another has appeared (validation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a table, Quesma uses both the schema information (which can come from "PUT /:index/_mapping" or YAML configuration) and the inferred types from JSON. However, the schema information does not contain knowledge whether a field is an array or not - in ElasticSearch essentially every field can become an array (a field with type "keyword" can receive an array of keywords).
Therefore Quesma has to handle arrays in a different way. Previously if it detected an array, it would not use schema information at all. This PR improves this logic - schema information is now combined with the JSON information (that a field is actually an array).