Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance #87

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Maintenance #87

merged 5 commits into from
Mar 8, 2024

Conversation

gdude2002
Copy link
Contributor

@gdude2002 gdude2002 commented Feb 29, 2024 •
edited
Loading

This is a maintenance PR that makes the following changes:

  • Update all the dependencies, including Gradle, Gradle plugins and KordEx
  • Remove verification role logic and configuration
  • Update Java version in CI to Java 17
  • Make the Json instance used by the Minecraft extension ignore unknown keys (wasn't it like this before?)

sschr15
sschr15 reviewed Feb 29, 2024
View reviewed changes
Copy link
Member

@sschr15 sschr15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, aside from the now unnecessary suppression

src/main/kotlin/org/quiltmc/community/_Utils.kt Show resolved Hide resolved
@sschr15 sschr15 merged commit ae9d300 into QuiltMC:root Mar 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sschr15 sschr15 sschr15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdude2002 @sschr15