Add named exports output format #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2021 14:51
This option creates named exports in the output as opposed to using a default export. This is intended to be used in combination with the `namedExports` options in webpack's `css-loader` and `style-loader` config, which enable proper tree shaking of the final CSS.
Closed
|
@LucaColonnello Does this PR close #94 ? |
This one does not, but I guess we could easily add this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
namedExportsoption to the cli and theDtsCreatorclass.This option formats the
.d.tsoutput using named exports as opposed to a default export.Why
When using css-modules, one of the various advantages is tree shaking offered by webpack or other compilers,
as the system knows first hand what you're using from your imports.
When enabling this css-modules feature (available in webpack's
css-loaderandstyle-loader),the generated style modules will use named exports. This behaviour is not reflected in this module
as default exports are always used in the generated
.d.ts.Related to: #99