Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add singleQuote option to allow custom style for keys with dashes #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lgraziani2712
Copy link

@lgraziani2712 lgraziani2712 commented Nov 22, 2019

Hello! I'm having this issue when running with webpack, it updates the .d.ts related files changing the style defined by prettier. This shows a lot of false positives changed files because prettier styles our .d.ts files and differs with what the lib does.

Also, keys without dashes get the quotes removed, like a JS object key.

In this PR I address this problem.

Thank you for your work!

PS: the gitatribute files and all are because I'm using windows, and had trouble with the EOL's.

@lgraziani2712
Copy link
Author

BTW, I'm already using this PR in a codebase with more than 100 less files, and nothing went wrong 👍

@drackp2m
Copy link

It's not bad that you have a preference for single quotes. I like them better too!!

But you should not modify the style of the original code when making a PR

Your PR has conflicts, and too many modifications (like changes of double quotes for simple ones, or line breaks in texts that are too long). Besides, you have also uploaded some configuration files of your IDE. Like editorconfig, gitattributes, prettier, etc. You shouldn't have committed those files!

Check all of that, update your pull request and maybe one day it will be approved.

I'd be happier with those single quotes too!!

@lgraziani2712 lgraziani2712 force-pushed the add-single-quote-option branch from 9b7a8ac to 84661b9 Compare September 19, 2022 15:03
@lgraziani2712 lgraziani2712 force-pushed the add-single-quote-option branch from 84661b9 to 45a6cfb Compare September 19, 2022 15:29
@lgraziani2712
Copy link
Author

lgraziani2712 commented Sep 19, 2022

Sry the delay! I just rebased and fixed the extra noise in the code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants