fix: specify required node range (#3101)

fixes #3035
QwikDev · Feb 23, 2023 · 3bb72d1 · 3bb72d1
1 parent 3ed5d99
commit 3bb72d1
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -129,7 +129,7 @@
   ],
   "packageManager": "[email protected]",
   "engines": {
-    "node": ">=16",
+    "node": ">=16.8.0 <18.0.0 || >=18.11",
     "npm": "please-use-pnpm",
     "yarn": "please-use-pnpm",
     "pnpm": ">=7.18.0"

diff --git a/packages/create-qwik/index.ts b/packages/create-qwik/index.ts
@@ -44,6 +44,14 @@ function checkNodeVersion() {
         )
       );
     }
+  } else if (Number(majorVersion) === 18) {
+    if (Number(minorVersion) < 11) {
+      console.error(
+        color.red(
+          `Node.js 18.11 or higher is REQUIRED. From Node 18.0.0 to 18.11.0, there is a bug preventing correct behaviour of Qwik. You are currently running Node.js ${version}. https://github.com/BuilderIO/qwik/issues/3035`
+        )
+      );
+    }
   }
 }
 

diff --git a/packages/create-qwik/package.json b/packages/create-qwik/package.json
@@ -32,7 +32,7 @@
     "kleur": "4.1.5"
   },
   "engines": {
-    "node": ">=16",
+    "node": ">=16.8.0 <18.0.0 || >=18.11",
     "npm": ">=6.0.0"
   }
 }
diff --git a/packages/qwik-auth/package.json b/packages/qwik-auth/package.json
@@ -14,7 +14,7 @@
     "build": "vite build --mode lib"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=16.8.0 <18.0.0 || >=18.11"
   },
   "exports": {
     ".": {

diff --git a/packages/qwik-city/package.json b/packages/qwik-city/package.json
@@ -157,6 +157,9 @@
   "bugs": {
     "url": "https://github.com/BuilderIO/qwik/issues"
   },
+  "engines": {
+    "node": ">=16.8.0 <18.0.0 || >=18.11"
+  },
   "private": true,
   "publishConfig": {
     "access": "public"

diff --git a/packages/qwik/package.json b/packages/qwik/package.json
@@ -178,6 +178,6 @@
     "Builder.io"
   ],
   "engines": {
-    "node": ">=16.8.0"
+    "node": ">=16.8.0 <18.0.0 || >=18.11"
   }
 }
diff --git a/starters/apps/base/.npmrc b/starters/apps/base/.npmrc
@@ -0,0 +1 @@
+engine-strict=true
diff --git a/starters/apps/base/package.json b/starters/apps/base/package.json
@@ -32,5 +32,8 @@
     "vite": "latest",
     "vite-tsconfig-paths": "3.5.0"
   },
+  "engines": {
+    "node": ">=16.8.0 <18.0.0 || >=18.11"
+  },
   "private": true
 }