Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQLAlchemy.destroy: open() does not return an SQLAlchemy engine object #105

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Dec 17, 2023

Dear Mark,

thanks a stack for conceiving this excellent package.

While working on GH-106, we discovered a minor flaw in the SQLAlchemy.destroy method. This patch fixes it. Along the lines, it slightly adjusts the .gitignore file, and the pytest configuration options.

With kind regards,
Andreas.

@amotl amotl mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant