Support R session requests by hosting a tcp server #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tal500
changed the title
added 6 commits
July 24, 2023 15:56
added 12 commits
August 1, 2023 14:42
…nding command by vscode
Tal500
force-pushed
the
tcp-incoming-request-server
branch
from
2cc2504 to
6f6199d
Compare
added 6 commits
August 3, 2023 17:49
…even when we have file system error on previous lock file
renkun-ken
reviewed
Oct 7, 2023
R/session/vsc.R
Outdated
| cat(get_timestamp(), file = plot_lock_file) | ||
| if (!is.na(request_tcp_connection)) { | ||
| tryCatch({ | ||
| plot_file_content <- readr::read_file_raw(plot_file) |
There was a problem hiding this comment.
Does readr::read_file_raw() behave differently from readBin(file, file.size(file))?
There was a problem hiding this comment.
Maybe readBin(file, file.size(file)) is good enough so that we don't have to introduce readr as a new dependency.
There was a problem hiding this comment.
Maybe
readBin(file, file.size(file))is good enough so that we don't have to introducereadras a new dependency.
You need to specify the correct encoding parameters, and I'm unable to make this work with jsonlite::base54_enc function with readBin.
renkun-ken
reviewed
Oct 8, 2023
added 7 commits
October 10, 2023 14:31
… the new R indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1359
Fixes #1391
Features:
init.Rafter R session init (and connect by it on pressing the status icon when opening a new terminal): Connect on already active R session viasource("~/.vscode-R/init_late.R"); .vsc.attach(host="YOUR_HOST", port = YOUR_PORT);. (since 873af37).vsc.detachto APINot Planned: