Substitute variables in r.rpath and r.rterm settings
#1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
#1398 allows specifying an R term path relative to the current workspace folder, which causes an undesirable behavior as described in #1437.
This PR no longer allows relative path but switches to an approach (more standard for vscode extensions) using variable substitutions in
r.rpathandr.rtermsettings.VS Code has built-in support for variable substitution in
launch.jsonandtasks.jsonfiles as described at https://code.visualstudio.com/docs/editor/variables-reference. We support a small subset of those variables which are most useful here:${userHome}- the path of the user's home folder${workspaceFolder}- the path of the folder opened in VS Code${fileWorkspaceFolder}- the current opened file's workspace folder${fileDirname}- the current opened file's folder pathWe could always add more if demanded.