Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase default length limit #9

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Increase default length limit #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10"]
python-version: ["3.9", "3.10", "3.11", "3.12"]

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ classifiers = [
]
keywords = ["changelog", "changelog-generator", "commit-style"]
dependencies = [
"git-changelog >= 2.0.0",
"git-changelog >= 2.5.0",
]
requires-python = ">=3.7"

Expand Down
2 changes: 1 addition & 1 deletion src/rhenvision_changelog/commit_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import sys

def check_commit(commit, jira_project, length_limit=70) -> int:
def check_commit(commit, jira_project, length_limit=135) -> int:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally not a birth date of someone I know :-)

if len(commit.subject) > length_limit:
sys.stderr.write("ERROR: Commit subject is too long (limit is " + str(length_limit) + "): " + commit.subject + "\n")
return 1
Expand Down
1 change: 1 addition & 0 deletions tests/test_changelog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
[email protected]
1669736056
HEAD -> branch, origin/branch
701eca9b345a940c8da0bab7fe601666ca9985b9
"""

class StubbedChangelog(ProvisioningChangelog):
Expand Down
1 change: 1 addition & 0 deletions tests/test_commmit_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
[email protected]
1669736056
HEAD -> branch, origin/branch
701eca9b345a940c8da0bab7fe601666ca9985b9
"""

class StubbedChangelog(ProvisioningChangelog):
Expand Down
Loading