-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys/ztimer/xtimer_compat: provide more fallback options #20494
base: master
Are you sure you want to change the base?
Conversation
Uncrustify is pretty unhappy with this one ;) |
0942fbb
to
8712ef9
Compare
8712ef9
to
a5c385a
Compare
I think the convention was to use We could discuss this in upcoming VMA and quickly vote on this. |
a5c385a
to
10888b3
Compare
I like this (xtimer_compat is a nice interface to ztimer). I just like to raise the question: "Could we somehow ensure that the user we somehow ensure the user knows about the mapping to ztimer_msec happening?"
|
10888b3
to
78be9db
Compare
78be9db
to
be2c455
Compare
What is that warning supposed to look like and what is it supposed to achieve?
|
IIUC this is causing troubles with Rust builds – but riot-wrappers doesn't wrap (and doesn't plan to wrap) XTimer. Does switching riot-sys in .cargo/config.toml to the branch of RIOT-OS/rust-riot-sys#51 solve the build issues? |
I thought of a warning in case of ztimer_msec providing the service for xtimer_usleep when it might have some influence on functionality |
Like so? |
Contribution description
The xtimer API can be used as a backend agnostic frontend to ztimer.
To better facilitate this (and also allow the use without a timer for simple sleep operations), add more fall-back implementations.
Testing procedure
Issues/PRs references
alternative to #19719