Runtime stride #294
Merged
Runtime stride #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlangbe
requested review from
a team,
cgmillette,
bragadeesh,
CongMa13 and
afanfa
as code owners
|
@dlangbe Is there anything to add to the changelog for this? |
Yes, the changelog should reflect the naming change of |
|
@dlangbe Thanks for the clarification. After you update the change log, I can review it for formatting, etc. |
cgmillette
reviewed
Nov 20, 2024
cgmillette
reviewed
Nov 20, 2024
cgmillette
reviewed
Nov 20, 2024
dlangbe
force-pushed
the
runtime-stride
branch
from
a4e26f9
to
5f61180
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to change the default stride layout at runtime with environment variable
HIPTENSOR_DEFAULT_STRIDES_COL_MAJOR.Renamed
HIPTENSOR_DATA_LAYOUT_COL_MAJOR -> HIPTENSOR_DEFAULT_STRIDES_COL_MAJOR