External TW_STIME #178
Open
External TW_STIME #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MPI allreduce should use double type, otherwise it must be reimplemented - missing MAX reference
allow for model-defined tw_stime type. code should live in model repo, not ROSS.
Codecov Report
@@ Coverage Diff @@
## develop #178 +/- ##
==========================================
Coverage ? 58.26%
==========================================
Files ? 33
Lines ? 3563
Branches ? 0
==========================================
Hits ? 2076
Misses ? 1487
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes the loop on how the TW_STIME API should be implemented by model developers. It does not make sense for a model-specific tw_stime to be added to ROSS core, particularly if the tw_stime object needs to be developed over time as the model is developed. With this PR, model developers can tell ROSS at configuration time where to find the implementation of tw_stime class, files which may exist outside of the ROSS repo.
I definitely need to update the TW_STIME API documentation. I’ve run local tests and there should be no impact to models which do not take advantage of this.
This replaces #168.
If this merge represents a feature addition to ROSS, the following items must be completed before the branch will be merged:
Include a link to your blog post in the Pull Request.