Include all bridges in tarballs #4286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, two "demo" and "example" bridges are excluded from GitHub's autogenerated tarballs. As I argued, those files can still be helpful for integration tests, as they are run in NixOS and don't need internet access or depend on the availability of external services [1]. Additionally, the official docker image builds from the checkout so it includes those bridges when users use containers or a git checkout compared to tarballs. This commit therefore unifies the list of available bridges between deployment methods. [1] https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/web-apps/rss-bridge.nix#L20
|
Should be in the tarball, so remove them from the ignore-export list. Maybe @logmanoriginal still remembers why he removed them 5 years ago and if we are overlooking a reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, two "demo" and "example" bridges are excluded from GitHub's autogenerated tarballs. As I argued, those files can still be helpful for integration tests, as they are run in NixOS and don't need internet access or depend on the availability of external services [1].
Additionally, the official docker image builds from the checkout so it includes those bridges when users use containers or a git checkout compared to tarballs. This commit therefore unifies the list of available bridges between deployment methods.
Either we include those bridges in the tarball (preferred) or we exclude them from docker images as well.
[1] https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/web-apps/rss-bridge.nix#L20