Skip to content

Commit

Permalink
Cygwin: disable high-entropy VA for ldh
Browse files Browse the repository at this point in the history
If ldd is run against a DLL which links to the Cygwin DLL, ldh will end
up loading the Cygwin DLL dynamically, much like cygcheck or strace.

Addresses: https://cygwin.com/pipermail/cygwin/2024-May/255991.html
Fixes: 60675f1 ("Cygwin: decouple shared mem regions from Cygwin DLL")
Reviewed-by: Ken Brown <[email protected]>, Takashi Yano <[email protected]>
Signed-off-by: Jeremy Drake <[email protected]>
  • Loading branch information
Jeremy Drake via Cygwin-patches authored and tyan0 committed Jun 2, 2024
1 parent d49c6a7 commit 84dff09
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions winsup/cygwin/release/3.5.4
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@ Fixes:
- Fix regression of pthread::once() introduced in 3.5.0 (i.e., the race
issue regarding destroying mutex).
Addresses: https://cygwin.com/pipermail/cygwin/2024-May/255987.html

- Fix a problem that ldd command against cygwin DLLs sometimes hangs.
Addresses: https://cygwin.com/pipermail/cygwin/2024-May/255991.html
1 change: 1 addition & 0 deletions winsup/utils/mingw/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ cygcheck_LDADD = -lz -lwininet -lshlwapi -lpsapi -lntdll
cygwin_console_helper_SOURCES = cygwin-console-helper.cc

ldh_SOURCES = ldh.cc
ldh_LDFLAGS = ${AM_LDFLAGS} -Wl,--disable-high-entropy-va

strace_SOURCES = \
path.cc \
Expand Down

0 comments on commit 84dff09

Please sign in to comment.