Cuda array interface #43
Open
+185
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit CudaDataManager::GetGPUBufferPointer() returned a pointer to the GPU buffer pointer. Its return type should have been void**. Every usage of this method across RTK and CudaCommon dereference the returned pointer pointer, so just return the buffer pointer directly as it required for future commits adding support for __cuda_array_interface__
Adapt ITK's PyBuffer approach to inject __cuda_array_interface__ in wrapped code. Closes RTKConsortium#10
This allows modules like RTK to easily reuse files from the CudaCommon sources, e.g. CudaImage.i.init and CudaImage.i.in
SimonRit
force-pushed
the
cuda-array-interface
branch
from
9e356cf to
e176586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding export code to #42