-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue679 interzonal elements, soil temperature, and interior geometry estimation #785
Open
PGorzalka
wants to merge
52
commits into
RWTH-EBC:main
Choose a base branch
from
PGorzalka:issue679_custom_paths_interzonal_soil
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Issue679 interzonal elements, soil temperature, and interior geometry estimation #785
PGorzalka
wants to merge
52
commits into
RWTH-EBC:main
from
PGorzalka:issue679_custom_paths_interzonal_soil
+566,460
−844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackage without setup outside parameter added to outer wall
…useconditions now cover interzonal air exchange and heat flow parameters outside parameter removed from outerwall tabula_de archetype generation and thermalzone adapted for introducing external geometry, including adjustments to innerwall, floor and ceiling
…truction, different type when creating teaser building parts from btom building parts
…nnections inner ir emissivity calculation bugfix
…alculation' into 1-thermal-zone-connections
some changes in parameter handling due to inconsistencies in previous version
adjustment regarding resistance orientation of nz borders
… apply optional plaster
… 4-contribute-dlr-changes-to-open-source-repository # Conflicts: # data/input/inputdata/UseConditions.json # data/output/aixlib_output.py # data/output/modelicatemplate/AixLib/AixLib_Multizone # data/output/modelicatemplate/modelica_test_script # data/output/runUnitTests.py # logic/buildingobjects/calculation/aixlib.py # logic/buildingobjects/calculation/four_element.py # teaser/logic/archetypebuildings/tabula/de/singlefamilyhouse.py
…es that should not be contributed and consistency of those that should be.
…neighbored zone functionality in InnerWall and its children
added a FiveElement template
… of five element.
…s with selection. change integration of inner wall area approximation.
…new parameters and features
…, test of inner wall calculation approach added, additional internal gains removed
…ons to the overall code made after discussing everything with David
added new tests that revelead other errors: concise solution for handling interzonal elements depending on properties of the zones still needs to be implemented.
… on properties of the zones
…if interzonals are treated as inner elements
…tom_paths_interzonal_soil # Conflicts: # teaser/data/input/buildingelement_input_json.py # teaser/data/output/aixlib_output.py # teaser/data/output/modelicatemplate/AixLib/AixLib_Multizone # teaser/data/output/modelicatemplate/AixLib/AixLib_ThermalZoneRecord_FourElement # teaser/data/output/modelicatemplate/AixLib/AixLib_ThermalZoneRecord_ThreeElement # teaser/data/output/modelicatemplate/AixLib/AixLib_ThermalZoneRecord_TwoElement # teaser/logic/archetypebuildings/bmvbs/custom/institute.py # teaser/logic/archetypebuildings/bmvbs/custom/institute4.py # teaser/logic/archetypebuildings/bmvbs/custom/institute8.py # teaser/logic/archetypebuildings/bmvbs/office.py # teaser/logic/archetypebuildings/bmvbs/singlefamilydwelling.py # teaser/logic/archetypebuildings/residential.py # teaser/logic/archetypebuildings/tabula/de/apartmentblock.py # teaser/logic/archetypebuildings/tabula/de/multifamilyhouse.py # teaser/logic/archetypebuildings/tabula/de/singlefamilyhouse.py # teaser/logic/archetypebuildings/tabula/de/terracedhouse.py # teaser/logic/archetypebuildings/tabula/dk/apartmentblock.py # teaser/logic/archetypebuildings/tabula/dk/singlefamilyhouse.py # teaser/logic/archetypebuildings/tabula/dk/terracedhouse.py # teaser/logic/archetypebuildings/urbanrenet/est1a.py # teaser/logic/archetypebuildings/urbanrenet/est1b.py # teaser/logic/archetypebuildings/urbanrenet/est2.py # teaser/logic/archetypebuildings/urbanrenet/est3.py # teaser/logic/archetypebuildings/urbanrenet/est4a.py # teaser/logic/archetypebuildings/urbanrenet/est4b.py # teaser/logic/archetypebuildings/urbanrenet/est5.py # teaser/logic/archetypebuildings/urbanrenet/est6.py # teaser/logic/archetypebuildings/urbanrenet/est7.py # teaser/logic/archetypebuildings/urbanrenet/est8a.py # teaser/logic/archetypebuildings/urbanrenet/est8b.py # teaser/logic/buildingobjects/buildingphysics/wall.py # teaser/logic/buildingobjects/calculation/aixlib.py # teaser/logic/buildingobjects/calculation/four_element.py # teaser/logic/buildingobjects/calculation/one_element.py # teaser/logic/buildingobjects/calculation/three_element.py # teaser/logic/buildingobjects/calculation/two_element.py # teaser/logic/buildingobjects/thermalzone.py # teaser/project.py # tests/test_data.py
…nd made interzonal import/export choices more concise. Tests are successful for now
…evelopment branch
…m_paths_interzonal_soil
added ASHRAE 140 Case 960 into example 11 version update in json files added separate tests for building elements with interzonals minor fixes
…hs_interzonal_soil # Conflicts: # teaser/logic/buildingobjects/calculation/aixlib.py
Open
Thanks for providing the PR! I did the same as Fabian in AixLib and provided you a branch that runs our CI: #786 This CI is not that complete as in AixLib but will run the unit tests to see if anything goes wrong. |
…rature data source selector in AixLib
@DaJansenGit added your commits to the CI branch and renamed the ground temperature selector in the records as you suggested in the AixLib PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, I was able to finish the work on issue #679
@DaJansenGit thanks for your support!
Changes mainly encompass the work mentioned in this paper:
InterzonalWall
,InterzonalCeiling
andInterzonalFloor
'typical_minus_outer'
sets length of inner walls = 2 * typical length * height of floors + 2 * typical width * height of floors - length of outer or interzonal walls'typical_minus_outer_extended'
like'typical_minus_outer'
, but also considers thata) a non-complete "average room" reduces its circumference proportional to the square root of the area
b) rooftops, windows and ground floors (= walls with border to soil) may have a vertical share
Additional minor stuff:
each
s inAixLib.Fluid.Pools.BaseClasses.AirFlowMoistureToROM
caused OM to fail -> fixedmodelica:
to reference to existing Modelica resourcesMissing:
For AixLib you should always use 2 elements!!!
-> what should be written there?See also PR 1546 in AixLib
Looking forward to your feedback on the changes!