-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
771 add besmod export #789
base: main
Are you sure you want to change the base?
Conversation
new calculation with infiltration rate 0.5 instead of 0.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature looks really good, thanks for the hard work. I will test it locally, but I expect only these comments. Address them as you see fit. Only aspect would be backwards compatibility with base_infiltration, which we could quickly discuss with @DaJansenGit
…pyter Notebook format.
…add-besmod-export
@HvanderStok Aside from the mentioned comments, this feature looks really cool. I still found some One "issue" was that I had an extended version of TEASERThermalZone in my own code. However, the feature of this custom model is nice for others, as well, so I added it in BESMod. If users require this, they could just override the template file if they find it annoying or use own modifiers. |
|
Closes #733, #746 and #771.
Needs new BESMod version 0.6.0 RWTH-EBC/BESMod#101 and the used AixLib version is increased to 2.1.1.
Additionally, the
use_conditions
parameterinfitration_rate
is renamed tobase_infiltration
, as it was already named in the documentation and the parameterstatic_infiltration
is added which is now used for the static heat load calculation with a value of 0.5.