WIP: Support for lcov/gcov with Ninja #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the combinations (ninja,make) x (gcov,lcov)
If run from the *current* binary dir, gcov gives errors such as: Cannot open source file ../src/libfoo/foo.c The gcov files are all created in the same dir, but the -p option should guarantee there are no name clashes
This seems the only way to make all the ninja/make combinations happy. If this is really the case, some cleanup is needed. External code should be excluded through LCOV_REMOVE_PATTERNS.
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 4 -1
Lines 20 17 -3
=========================================
- Hits 20 17 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to better integrate the Ninja build system (issue #29, but also #6).
It is just meant for discussion, for there are still a few things to sort out, e.g. the target versions of CMake, Ninja, gcc, ... It's a bit of a mess.
Whatever the response, it would be nice to have a github action that runs tests for at least some combinations of the above.