arduino-hal: provide renamed types matching fields #559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very simple improvement to fix #558 and fix #555.
The approach is a basic application of renaming with
paste!
, but I choose to generate slightly different code than suggested:In rust-analyzer the type aliases are resolved to the underlying type, so in this implementation the documentation popups still show the MCU names. We could fix this by using a newtype with
Deref
, but that seems like overkill.