-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UsartSpi Support #588
Open
armandas
wants to merge
29
commits into
Rahix:main
Choose a base branch
from
armandas:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
UsartSpi Support #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs to be tested. Will test via Arudino UNO when I move them ig
…ny SPI modules to test on...
…cludes rejig of pin layouts between boards.
… doesn't have the right pins. Will fix that soon. If someone else can test would be great.
(Tested)[Rahix#562 (comment)]. Introduces points for other examples commented in.
Co-authored-by: Armandas Jarušauskas <[email protected]>
Add reset to USART.
Separate constructor is used to remove the need for passing a CS pin.
Hmm,
#[doc = "Writes raw bits to the register."]
#[inline(always)]
pub fn bits(&mut self, bits: u16) -> &mut Self {
unsafe { self.0.bits(bits) };
self
}
#[doc = "Writes raw bits to the register."]
#[inline(always)]
pub unsafe fn bits(&mut self, bits: u16) -> &mut Self {
self.0.bits(bits);
self
} |
Turns out it was not so hard to fix the above issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of the @CoolSlimbo's good work in #562. Closes #561.
I've made the following changes:
new_from_usart
usart_spi-feedback
exampleI have run the
usart_spi-feedback
example on an Arduino Mega 2560 and confirmed that USART 1, 2 and 3 work.