Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make attiny_hal::pins! and atmega_hal::pins! feature-agnostic #603

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

innermatrix
Copy link

@innermatrix innermatrix commented Nov 21, 2024

This removes the feature-specific (and therefore MCU-specific) pins! macro and replaces it with a feature-agnostic pins! macro + an MCU-specific wrapper function.

This is initial work to enable a refractor that will switch all crates in arduino-hal to use additive features, as is the recommended best practice. See #602 for more context.

Testing:

  • Verified that cargo build -p arduino-hal --features <board> succeeds for all boards
  • Verified that cargo build --bins succeeds for every example/*

Using stacked PRs — see innermatrix#1 (comment) for a preview of the follow-on work in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant