Make attiny_hal::pins! and atmega_hal::pins! feature-agnostic #603
+70
−91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the feature-specific (and therefore MCU-specific)
pins!
macro and replaces it with a feature-agnosticpins!
macro + an MCU-specific wrapper function.This is initial work to enable a refractor that will switch all crates in
arduino-hal
to use additive features, as is the recommended best practice. See #602 for more context.Testing:
cargo build -p arduino-hal --features <board>
succeeds for all boardscargo build --bins
succeeds for everyexample/*
Using stacked PRs — see innermatrix#1 (comment) for a preview of the follow-on work in progress.