Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display out of stock badge for products on order creation page #388

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Display out of stock badge for products on order creation page #388

merged 2 commits into from
Sep 17, 2024

Conversation

marlena-b
Copy link
Collaborator

@marlena-b marlena-b commented Aug 28, 2024 •
edited
Loading

Issue: #376

Client View:
Zrzut ekranu 2024-08-28 o 11 08 06

Admin View:
Zrzut ekranu 2024-09-16 o 16 14 52

@netlify Netlify
Copy link

netlify bot commented Aug 28, 2024 •
edited
Loading

❌ Deploy Preview for ecommerce-events failed.

Name Link
🔨 Latest commit 3f485ec
🔍 Latest deploy log https://app.netlify.com/sites/ecommerce-events/deploys/66e854a65eb8940008074233

@marlena-b marlena-b force-pushed the display-out-of-stock-badge branch from 3e7af2f to fdede5b Compare September 3, 2024 10:36
@andrzejkrzywda
Copy link
Contributor

Two things here:

  1. In the client orders read model we need a boolean flag, we dont need integer here, let's adjust
  2. In the admin/sales orders read model, let's keep it as integer, but lets create a new ticket where we display the number - this is a good opportunity to diverge these two read models from each other

@andrzejkrzywda andrzejkrzywda merged commit 95d29d1 into master Sep 17, 2024
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrzejkrzywda andrzejkrzywda andrzejkrzywda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marlena-b @andrzejkrzywda