Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor discounts #422

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Refactor discounts #422

merged 1 commit into from
Nov 26, 2024

Conversation

marlena-b
Copy link
Collaborator

I refactored discounts according to what was discussed in this PR: #409

  • renamed all of the places with the reset_discount and similar to remove_discount because it better reflects what this code does.
  • moved type to the PercentageDiscount.

@marlena-b marlena-b requested review from lukaszreszke and andrzejkrzywda and removed request for lukaszreszke November 25, 2024 17:13
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

❌ Deploy Preview for ecommerce-events failed.

Name Link
🔨 Latest commit 9075c73
🔍 Latest deploy log https://app.netlify.com/sites/ecommerce-events/deploys/6744b0445a6a860008ee583a

lukaszreszke
lukaszreszke approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@lukaszreszke lukaszreszke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done :)

@marlena-b marlena-b merged commit e668817 into master Nov 26, 2024
54 of 58 checks passed
@marlena-b marlena-b mentioned this pull request Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszreszke lukaszreszke lukaszreszke approved these changes

@andrzejkrzywda andrzejkrzywda Awaiting requested review from andrzejkrzywda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marlena-b @lukaszreszke