Merge pull request projectlombok#3494 from Rawi01/enum-getter

Remove javac support for getter on enum members
Rawi01 · Sep 17, 2023 · 67cd7a6 · 67cd7a6
2 parents 6623e12 + da00406
commit 67cd7a6
Show file tree

Hide file tree

Showing 7 changed files with 22 additions and 2 deletions.
diff --git a/src/core/lombok/eclipse/handlers/HandleGetter.java b/src/core/lombok/eclipse/handlers/HandleGetter.java
@@ -168,7 +168,7 @@ public void createGetterForFields(AccessLevel level, Collection<EclipseNode> fie
 	public void createGetterForField(AccessLevel level,
 			EclipseNode fieldNode, EclipseNode errorNode, ASTNode source, boolean whineIfExists, boolean lazy, List<Annotation> onMethod) {
 
-		if (fieldNode.getKind() != Kind.FIELD) {
+		if (fieldNode.getKind() != Kind.FIELD || fieldNode.isEnumMember()) {
 			errorNode.addError(GETTER_NODE_NOT_SUPPORTED_ERR);
 			return;
 		}

diff --git a/src/core/lombok/javac/handlers/HandleGetter.java b/src/core/lombok/javac/handlers/HandleGetter.java
@@ -165,7 +165,7 @@ public void createGetterForFields(AccessLevel level, Collection<JavacNode> field
 	public void createGetterForField(AccessLevel level,
 			JavacNode fieldNode, JavacNode source, boolean whineIfExists, boolean lazy, List<JCAnnotation> onMethod) {
 
-		if (fieldNode.getKind() != Kind.FIELD) {
+		if (fieldNode.getKind() != Kind.FIELD || fieldNode.isEnumMember()) {
 			source.addError(GETTER_NODE_NOT_SUPPORTED_ERR);
 			return;
 		}

diff --git a/test/transform/resource/after-delombok/GetterEnumConstant.java b/test/transform/resource/after-delombok/GetterEnumConstant.java
@@ -0,0 +1,3 @@
+enum GetterEnumConstant {
+	ONE;
+}
diff --git a/test/transform/resource/after-ecj/GetterEnumConstant.java b/test/transform/resource/after-ecj/GetterEnumConstant.java
@@ -0,0 +1,9 @@
+import lombok.Getter;
+enum GetterEnumConstant {
+  @Getter ONE(),
+  <clinit>() {
+  }
+  GetterEnumConstant() {
+    super();
+  }
+}
diff --git a/test/transform/resource/before/GetterEnumConstant.java b/test/transform/resource/before/GetterEnumConstant.java
@@ -0,0 +1,6 @@
+import lombok.Getter;
+
+enum GetterEnumConstant {
+	@Getter
+	ONE;
+}
diff --git a/test/transform/resource/messages-delombok/GetterEnumConstant.java.messages b/test/transform/resource/messages-delombok/GetterEnumConstant.java.messages
@@ -0,0 +1 @@
+4 @Getter is only supported on a class, an enum, or a field.
diff --git a/test/transform/resource/messages-ecj/GetterEnumConstant.java.messages b/test/transform/resource/messages-ecj/GetterEnumConstant.java.messages
@@ -0,0 +1 @@
+4 @Getter is only supported on a class, an enum, or a field.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		4 @Getter is only supported on a class, an enum, or a field.