-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update main.go #1
base: main
Are you sure you want to change the base?
Conversation
Hi! Nice to meet you! Can you please make it as a pull request? At least for now, later on for sure I will add you write permission Also I will write you to the contributors :) |
pass := os.Getenv("SSH_PASS") | ||
host := os.Getenv("SSH_HOST") | ||
port := os.Getenv("SSH_PORT") | ||
user := "root" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is leftover
printUsage() | ||
log.Fatal(errOf) | ||
} | ||
shouldMountHTML := os.Getenv("MOUNT_HTML") == "true" || os.Getenv("MOUNT_HTML") == "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to delete it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it because I thought the HTML always needed to be included in the project, directly within the Docker setup. However, you can keep it if you prefer.
Here is another example, but this one is with fiber:
Go WebSSH to WebSocket with Fiber
https://github.com/lordbasex/golang-examples/tree/main/go-webssh-to-websocket
https://github.com/lordbasex/golang-examples
De: 'Adam Raźniewski' via info ***@***.***>
Fecha: miércoles, 22 de mayo de 2024, 12:54
Para: Razikus/go-ssh-to-websocket ***@***.***>
CC: iPERFEX TEAM ***@***.***>, Author ***@***.***>
Asunto: Re: [Razikus/go-ssh-to-websocket] Update main.go (PR #1)
@Razikus requested changes on this pull request.
________________________________
In src/main.go<#1 (comment)>:
@@ -20,10 +25,10 @@ var upgrader = websocket.Upgrader{
}
func sshHandler(w http.ResponseWriter, r *http.Request) {
- user := os.Getenv("SSH_USER")
- pass := os.Getenv("SSH_PASS")
- host := os.Getenv("SSH_HOST")
- port := os.Getenv("SSH_PORT")
+ user := "root"
This is leftover
________________________________
In src/main.go<#1 (comment)>:
func main() {
- errOf := checkForVariables()
- if errOf != nil {
-
- printUsage()
- log.Fatal(errOf)
- }
- shouldMountHTML := os.Getenv("MOUNT_HTML") == "true" || os.Getenv("MOUNT_HTML") == ""
Why to delete it?
—
Reply to this email directly, view it on GitHub<#1 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACK6ORCKPAQQUPRGFVSVJCLZDS5T7AVCNFSM6AAAAABIDYKDVOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZRGY4DQNRRGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
De: 'Adam Raźniewski' via info ***@***.***>
Fecha: miércoles, 22 de mayo de 2024, 12:54
Para: Razikus/go-ssh-to-websocket ***@***.***>
CC: iPERFEX TEAM ***@***.***>, Author ***@***.***>
Asunto: Re: [Razikus/go-ssh-to-websocket] Update main.go (PR #1)
@Razikus requested changes on this pull request.
________________________________
In src/main.go<#1 (comment)>:
@@ -20,10 +25,10 @@ var upgrader = websocket.Upgrader{
}
func sshHandler(w http.ResponseWriter, r *http.Request) {
- user := os.Getenv("SSH_USER")
- pass := os.Getenv("SSH_PASS")
- host := os.Getenv("SSH_HOST")
- port := os.Getenv("SSH_PORT")
+ user := "root"
This is leftover
________________________________
In src/main.go<#1 (comment)>:
func main() {
- errOf := checkForVariables()
- if errOf != nil {
-
- printUsage()
- log.Fatal(errOf)
- }
- shouldMountHTML := os.Getenv("MOUNT_HTML") == "true" || os.Getenv("MOUNT_HTML") == ""
Why to delete it?
I removed it because I thought the HTML always needed to be included in the project, directly within the Docker setup. However, you can keep it if you prefer.
—
Reply to this email directly, view it on GitHub<#1 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACK6ORCKPAQQUPRGFVSVJCLZDS5T7AVCNFSM6AAAAABIDYKDVOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZRGY4DQNRRGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I will review that in the weekend and change some stuff nice! |
Hi Razikus,
My name is Federico Pereira (https://github.com/lordbasex), and I would like to request permission to push to your repository https://github.com/Razikus/go-ssh-to-websocket.
I have been working on some improvements that I believe could benefit the project, and I would like to share them with you and the community. If it’s okay with you, could you grant me access to make the push? Alternatively, I would be happy to send you a pull request with the proposed changes.
Thank you in advance for your consideration and for all the work you’ve done on this project.
Best regards,
Federico Pereira