Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main.go #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update main.go #1

wants to merge 1 commit into from

Conversation

iperfex-team
Copy link

Hi Razikus,

My name is Federico Pereira (https://github.com/lordbasex), and I would like to request permission to push to your repository https://github.com/Razikus/go-ssh-to-websocket.

I have been working on some improvements that I believe could benefit the project, and I would like to share them with you and the community. If it’s okay with you, could you grant me access to make the push? Alternatively, I would be happy to send you a pull request with the proposed changes.

Thank you in advance for your consideration and for all the work you’ve done on this project.

Best regards,
Federico Pereira

@Razikus
Copy link
Owner

Razikus commented May 22, 2024

Hi!

Nice to meet you!

Can you please make it as a pull request?

At least for now, later on for sure I will add you write permission

Also I will write you to the contributors :)

pass := os.Getenv("SSH_PASS")
host := os.Getenv("SSH_HOST")
port := os.Getenv("SSH_PORT")
user := "root"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is leftover

printUsage()
log.Fatal(errOf)
}
shouldMountHTML := os.Getenv("MOUNT_HTML") == "true" || os.Getenv("MOUNT_HTML") == ""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to delete it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it because I thought the HTML always needed to be included in the project, directly within the Docker setup. However, you can keep it if you prefer.

@iperfex-team
Copy link
Author

iperfex-team commented May 22, 2024 via email

@iperfex-team
Copy link
Author

iperfex-team commented May 22, 2024 via email

@Razikus
Copy link
Owner

Razikus commented May 24, 2024

I will review that in the weekend and change some stuff

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants