Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling of RMS yaml writer for speedup #2508

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Allow disabling of RMS yaml writer for speedup #2508

wants to merge 5 commits into from
+46 −5

Commits on Sep 16, 2024

  1. added input arg for disabling rms yaml write

    @ChrisBNEU @JacksonBurns
    ChrisBNEU authored and JacksonBurns committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    8790092 View commit details
    Browse the repository at this point in the history

  2. updated documentation

    @ChrisBNEU @JacksonBurns
    ChrisBNEU authored and JacksonBurns committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e4fc189 View commit details
    Browse the repository at this point in the history

  3. use molecule.smiles instead of molecule.to_smiles() in yaml writer 

    This should speed up execution time by accessing the property each time instead of regenerating it, see : ReactionMechanismGenerator#2499 (comment)
    @JacksonBurns
    JacksonBurns committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    8d815f8 View commit details
    Browse the repository at this point in the history

  4. disable rms writer in regression tests and input unit test

    @JacksonBurns
    JacksonBurns committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9b1c12d View commit details
    Browse the repository at this point in the history

  5. move rmsyaml test to the rmg functional tests

    @JacksonBurns
    JacksonBurns committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d400cb2 View commit details
    Browse the repository at this point in the history