-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree Generation for Cyclic Ether Formation #487
base: main
Are you sure you want to change the base?
Conversation
productNum = 2 | ||
|
||
autoGenerated = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised at this line 🤔 . Is it a bug, or does in not mean what I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think currently autoGenerated is defaulted to False and needs to be changed to True manually. @mjohnson541 it might be nice to default this to True?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be set to True here, I forgot to say that in developer hours. Having it be default True would be good once we've converted the majority of the trees, but right now we'd have to go through and manually set it to False for most of the families so I think for the moment it's easier to just add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or actually much better we should automatically set it when we generate the tree so that when it saves it saves as True!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this to the assorted PR in RMG-Py
d83b542
to
648f7fa
Compare
648f7fa
to
7a5b7e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Can you just squash the autoGenerated commit?
c2122df
to
1deff25
Compare
Replace the logic node to a more generalized node; Removed all nodes previously defined; Add number of reactants and products.
This will be replaced by new rules created by ATG anyway
The new rate rules are generated by the BM tree fitting notebook.
1deff25
to
2c8605f
Compare
Generated tree for Cyclic Ether Formation family. This is generated following the guidance of RMG developer hour (Jun 7, 2021).
Note: