-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Cathub kinetics #499
base: main
Are you sure you want to change the base?
Conversation
7108a94
to
e90a3b4
Compare
) | ||
|
||
entry( | ||
index = 80, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C3H6X2
and C3H5X2
are bidentate species and I don't think this should match this family
) | ||
|
||
entry( | ||
index = 82, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C3H5X2-2
and C3H4X2
are bidentate species
) | ||
|
||
entry( | ||
index = 83, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C3H5X2-3
and C3H4X2-2
are bidentate species
142e387
to
89ea1c6
Compare
only with Eas, As are None
these are reactions which currently dont match any of our families
The duplicate cathub reactions were converted to MultiArrh. However, we do not want to add these rates together, so I converted them to SurfaceArrhenius and selected the more recent calculation (SchumannSelectivity2018)
Since we now consider metal attrs when descending the tree, these need to be removed from thermo group entries
This is a WIP PR to add kinetic data from cat hub (https://www.catalysis-hub.org)