-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding surface training reactions #512
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Tingchenlee ! Great work! I was able to generate auto trees for a bunch of the families you added training data. This is a good test to see if there is anything wrong with the new training reactions. Also, you were able to generate models and add rules from training, which is another good test. One thing I did notice, however, is that I get slightly different Ea in J/mol when converting from eV:
For example, you have Ea = 1.49eV = 143770.1J/mol
and using RMG I get
RMG uses conversion factor of 96485.3423627019
to convert to J/mol. Since it is a small difference on the order of a few J/mol
(which is much less than the uncertainty of the calculation), I am approving this PR. In the future, we should try to use the same units from the paper, and let RMG do the conversion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what I did do
- check the description
- check that the orders of magnitudes for all of the values made sense
- check that I could access the sources with the information here
- found a spot where I need clarification for coverage dependence.
what I did NOT do
- redo any of the calculations (for A-factor or Ea). I don't think it is necessary.
- check every value against the value in the paper because it is too time consuming.
- verify the rank and degeneracy (I think we'd fail a unit test if these were wrong right?)
what I found:
- a few small typos
- a value that did not match the written description. The paper matches the written description so I think it needs to be changed. if somebody can sanity check me please do and I'll update it.
- some reactions don't have a facet because the paper used a single crystal reactor.
I can go back through and check the values against the papers, but that will take significantly more time and I don't think it is worth it. I am going to revise what is here after somebody sanity checks my comment above. I can take over this PR, I think Ting-Chen is probably not going to have time to be working on it anymore and it is almost ready.
input/kinetics/families/Surface_Abstraction/training/reactions.py
Outdated
Show resolved
Hide resolved
input/kinetics/families/Surface_Abstraction/training/reactions.py
Outdated
Show resolved
Hide resolved
shortDesc = """Surface_Adsorption_vdW""", | ||
longDesc = | ||
""" | ||
Training reaction from kinetics library: Surface/Methane/Vlachos_Rh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3974954
to
173c7f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks ok to me and passes all tests locally
a0a8109
to
0b7734f
Compare
…kinetics families. (Surface_Adsorption_Dissociative, Surface_Adsorption_Single, Surface_Dissociation and Surface_Dissociation_Beta)
…ion_Single and Surface_Adsorption_vdW families
0b7734f
to
e879eae
Compare
Adding more surface training data into kinetic families.
Mhadeshwar_Pt111
library is for diesel oxidation catalysts (DOC) system and has 52 training reactions (Ea vary depending on the reactions, most of the A factors are in the range of 10^11 to 10^13 (1/s)), not sure if we want to add these 52 reactions now (might affect carbon-related models?).Vlachos_Pt111
library is for methane oxidation and has 43 training reactions (Ea vary depending on the reactions, most of the A factors are in the range of 10^10 to 10^13 (1/s), sticking coefficient from 0.01 to 1), not sure if we want to add these 43 reactions now (might affect carbon-related models?).