-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lithium #605
base: main
Are you sure you want to change the base?
Lithium #605
Conversation
de85292
to
e856d91
Compare
since desorbed mols are liquid phase, change in entropy with adsorption to surface should be less
This reverts commit 98f52fc.
Abraham and Mintz parameters fitted using COSMO-RS data and solute parameter database viscosity parameters taken from DEC
Surface Carbonate CO 2F Decomposition is left out because it results in 4 products which RMG currently cannot handle
this includes the CCCBDB data and the calculations for wb97x-d3/def2-tzvp and ccsd(t)f12/ccpvdzf12//wb97x-d3/def2-tzvp the calculations for ccsd(t)f12/ccpvdzf12//wb97x-d3/def2-tzvp for Li2O are commented out because while valid they were not used in the BDE calculation because they create significant disagreement on the Li-O BDE value with LiOH and the LiOH Li-O bond is more similar to expected Li-O bonds of interest
since best not used for BACs while we have so limited Li data and LiOH is better choice
as a result of the changes in the AECs the H298 values (after AECs) for the calculated data has changed for the corresponding levels of theory
… carbonate compounds properties for the mixture are estimates
the old reactions were for an electronic state where the reaction was not barrierless
here we move to a higher up rule in the tree to estimate this particular reaction
based on Pynta calculations with a simple reaction error cancellation scheme
based on Pynta calculations
Hi Matt, I've been trying to have RMG-electrochem to work for the electrocatalytic CO2 reduction reaction. David has done some work on this for his thesis and had this branch: https://github.com/davidfarinajr/RMG-database/tree/electrocat_master. It seems that all three commits on this branch have been merged into the current One thing I've noticed is that on David's branch for RMG-Py: https://github.com/davidfarinajr/RMG-Py/tree/electrocat_master, he developed an |
So earlier this year I set aside two weeks to finish the work and paper associated with this branch, when I was debugging a number of the PCET families weren't working and weren't important to the electrolyte degradation system I was modeling. I wasn't aware anyone else was planning to do anything in this area and I figured rewriting them later was going to be about as much work as debugging them (due to changes during development) so I removed them. "ElectrodeReactor" isn't ringing any bells for me, I'm not familiar with it and I don't think it was ever part of the branch. There's no system that explicitly replaces those PCET families and I don't think there are any structural barriers that should stop them from being added. You should just be able to just pluck the family files and debug them, try to model them after the working surface electrochemical families. |
To clarify if you're not modeling the gas phase conditions I don't think there's any reason to not use LiquidSurfaceReactor. |
Hi Matt, I have several questions regarding the
For the CO2RR families, I used an older class Also, 3) would you recommend converting all |
|
Hi @mjohnson541 how do we deal with this PR with 110 commits and 557 files? Do we just pick out what needs to change to make electrochemistry function, and wave goodbye to some changes? @ssun30 aren't trying to model lithium, but we do need to get electrochemistry (eg. CO₂ reduction) functioning on a modern main. |
The conflicts listed here are almost entirely for reference set data which impacts Arkane, but not RMG runs (the only exception is the recommended file, which should be easy to deal with). We should get those in eventually, but those should be able to be easily separated from the RMG vital changes. |
I can try and dig through this relatively soon, but I don't have time right now. |
Contains all modifications of the database adding data for lithium species and reactions.