Separate pyrms tests #73
Open
+21
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we often spend a lot of time resolving pyrms errors, one possible solution is to temporarily separate tests for the pyrms simulate adapters from the other tests in T3. This would allow us to more easily focus on developing features of T3
We could also consider the
xfaildecorator if we expect these tests to frequently fail. However, "having the xfail marker will still run the test but won’t report a traceback once it fails" and the traceback is useful in case we can fix the error.This PR will likely fail since it does install open babel version 3, which is now required by RMG-Py and ARC