Remove UIImagePickerController+RACSignalSupport to fix AppStore upload NSPhotoLibraryUsageDescription key issue #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I agree. I suggest filing a radar. |
|
I see it as a breaking change :) I would suggest to extract Not sure about Carthage, can anybody suggest how to conditionally deliver |
|
Hi, I'm facing this issue too. Could you guys release a new version with this PR included ? BR, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous discussion: ReactiveCocoa/ReactiveCocoa#3190
I don't think adding a dummy key was a good solution. Having info.plist key set but having no features related to photo library is weird.
Should we remove this two files
UIImagePickerController+RACSignalSupport.h&UIImagePickerController+RACSignalSupport.m?