Skip to content

Commit

Permalink
update to Kotlin 1.1.2-2, with Java 1.8
Browse files Browse the repository at this point in the history
  • Loading branch information
@thomasnield
thomasnield committed May 3, 2017
1 parent 536b0fe commit d559516
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion build.gradle
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
buildscript {
ext.kotlin_version = '1.1.2'
ext.kotlin_version = '1.1.2-2'
repositories { jcenter() }
dependencies {
classpath 'com.netflix.nebula:gradle-rxjava-project-plugin:4.+',
Expand All @@ -9,6 +9,8 @@ buildscript {

group = 'io.reactivex.rxjava2'

sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8

apply plugin: 'nebula.rxjava-project'
apply plugin: 'kotlin'
Expand Down

3 comments on commit d559516

@jt70
Copy link

@jt70 jt70 commented on d559516 May 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, is Java 8 necessary? Seems like this will limit the ability to use this on older Android devices before API level 24 (https://developer.android.com/studio/preview/features/java8-support.html). My limited understanding is that Java 8 is only required to compile Kotlin 1.1+, but maybe you have other reasons to require it.

@JakeWharton
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. There's no reason to target Java 8 bytecode

@thomasnield
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this was my mistake when I was debugging the transition. Ill revert it back to Java 6.

Please sign in to comment.