[fix] Make clowdapp name match app-interface Template #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clowdapp name has to match the app interface template in order for optionalDependencies and Dependencies work properly with bonfire. The easiest place to fix this is here in the clowdapp file since changing it elsewhere would require changes to both the apps referencing it as well as the resource name in app-interface Signed-off-by: Stephen Adams <[email protected]>
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clowdapp name has to match the app interface template in order for
optionalDependencies and Dependencies work properly with bonfire.
The easiest place to fix this is here in the clowdapp file since
changing it elsewhere would require changes to both the apps referencing
it as well as the resource name in app-interface
Signed-off-by: Stephen Adams [email protected]
What?
Update the clowdapp name to match the name in app-interface
Why?
If the name in the clowdapp and the name in app-interface do not match, bonfire can not properly use the optionalDependencies or Dependencies list
How?
Change the name
Testing
Did you add any tests for the change?
Anything Else?
Any other notes about the PR that would be useful for the reviewer.
Secure Coding Practices Checklist Link
Secure Coding Checklist