RHCLOUD-36895 | refactor: reduce logging noise #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log messages about the ignored committed offsets are not really useful unless we are debugging problems with that. Therefore, we could simply leave an error log message for when the offset committing goes wrong, and a debug one when we really want to know that offsets are being committed. RHCLOUD-36895
dehort
requested changes
Dec 12, 2024
internal/kafka/kafka.go
Outdated
| break | ||
| } | ||
|
|
||
| l.Log.Debugf("Ignored OffsetsComitted: %#v", e) |
There was a problem hiding this comment.
What do you think about making this a trace level log?
There was a problem hiding this comment.
Yes, even better. Done!
internal/kafka/kafka.go
Outdated
| default: | ||
| l.Log.Infof("Ignored %v\n", e) | ||
| l.Log.Infof("Ignored %#v\n", e) |
There was a problem hiding this comment.
Can you add a bit more context to this log message? Maybe something like "Ignored kafka event"? I was a bit stumped the first time I saw the original log message. It took me a minute to figure out what I was seeing getting logged.
There was a problem hiding this comment.
Yes, that's a good idea too! Done!
RHCLOUD-36895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Puts the "Ignored OffsetCommitted" error messages under the "debug" log level.
Why?
The log messages about the ignored committed offsets are not really useful unless we are debugging problems with that. Therefore, we could simply leave an error log message for when the offset committing goes wrong, and a debug one when we really want to know that offsets are being committed.
Jira ticket
[RHCLOUD-36895]